fix: phantom ledger paths, SQL errors, deterministic case refs by chitcommit · Pull Request #60 · chittyos/chittycommand

chitcommit · 2026-03-25T17:04:41Z

Summary

Redirects phantom /api/evidence and /api/cases/* ledger paths to correct services (ChittyEvidence, ChittyCommand)
Fixes SQL errors in timeline/jobs routes (conditional query building, missing column references, null guards)
Uses deterministic case ref for ledger_case_id instead of entry UUID
Removes dead ledger API calls from MCP get_case_timeline tool

Test plan

tsc --noEmit passes
Timeline endpoint returns events without SQL errors
MCP get_case_timeline tool works end-to-end
Bridge ledger routes proxy correctly to ChittyLedger

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Expanded AI tool capabilities from 28 to 48 tools across 12 domains
- Added authenticated API endpoints for case timeline retrieval, litigation fact synthesis, email drafting, quality control review, and scrape job queue management
- Enhanced integration with evidence system for improved case fact and document aggregation
Documentation
- Updated system charter and API documentation to reflect expanded capabilities and new endpoints

Schema Overlord audit findings (6 fixes): - EvidenceFact: entity_type not type, amount_value not value, nullable fields from LEFT JOINs (confidence, verification_status, fact_type) - EvidenceDocument: file_name not filename, created_at not uploaded_at - searchDocuments: GET→POST (ChittyEvidence /search is POST) - getContradictions: pointed to facts?conflicts_only=true (no dedicated contradictions endpoint exists) - timeline.ts: map entity_type→type and amount_value→value for consumers - mcp.ts + litigation.ts: fix a.value→a.amount_value references Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Added 5 evidence tools: get_case_timeline, get_case_facts, get_case_contradictions, get_pending_facts, synthesize_case_facts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

@canon

- Add @canon governance annotations to entity_type fields in integrations.ts - Fix MCP JSDoc: "38 tools across 9 domains" → "48 tools across 12 domains" - Add date filtering to deadlines query in MCP get_case_timeline - Add ChittyLedger document fetching to MCP get_case_timeline for REST parity Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…endpoints - CHARTER.md: add ChittyEvidence dependency, timeline/litigation/jobs endpoints, update MCP tool count (28→48), add case timeline and litigation scope items - CHITTY.md: add same endpoints, update MCP tool count (32→48), add ChittyEvidence to direct API data sources Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adds missing columns from migrations 0008/0009 to schema.ts: - ccObligations: escalation tracking (5 cols) - ccRecommendations: planner-aware fields (6 cols) - ccEmailConnections + ccUserNamespaces: 2 new tables Also adds drizzle.config.ts and updates drizzle-orm to match drizzle-kit. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chatgpt-codex-connector · 2026-03-25T17:04:47Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

github-actions · 2026-03-25T17:04:50Z

@coderabbitai review
@copilot review
@codex review
@claude review
Adversarial review request: evaluate security, policy bypass paths, regression risk, and merge-gating bypass attempts.

chatgpt-codex-connector · 2026-03-25T17:05:02Z

To use Codex here, create a Codex account and connect to github.

coderabbitai · 2026-03-25T17:05:04Z

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 47607df5-d640-4fa1-9bd7-da30d63b4bdc

📥 Commits

Reviewing files that changed from the base of the PR and between 23cecc0 and c5ffcca.

⛔ Files ignored due to path filters (1)

package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (16)

CHARTER.md
CHITTY.md
CLAUDE.md
drizzle.config.ts
migrations/0000_aromatic_diamondback.sql
migrations/0001_dashing_bulldozer.sql
migrations/meta/0000_snapshot.json
migrations/meta/0001_snapshot.json
migrations/meta/_journal.json
package.json
src/db/schema.ts
src/lib/integrations.ts
src/routes/litigation.ts
src/routes/mcp.ts
src/routes/timeline.ts
tests/mcp.test.ts

📝 Walkthrough

Walkthrough

This PR adds a complete database schema with migrations, extends the MCP toolkit from 38–43 tools to 48 tools across 12 domains (including a new Evidence domain), introduces REST API endpoints for case timelines/litigation operations/scrape job management, updates type definitions to align with ChittyEvidence API changes, and refreshes documentation to reflect expanded capabilities.

Changes

Cohort / File(s)	Summary
Documentation Updates `CHARTER.md`, `CHITTY.md`, `CLAUDE.md`	Updated metadata, capability statements, and endpoint/data-source tables to reflect expanded MCP toolkit (48 tools across 12 domains), new authenticated REST endpoints for litigation/timeline/job management, and ChittyEvidence as upstream provider. Charter version bumped to 1.2.0.
Database Configuration & Migrations `drizzle.config.ts`, `package.json`, `migrations/0000_aromatic_diamondback.sql`, `migrations/0001_dashing_bulldozer.sql`, `migrations/meta/_journal.json`	Added Drizzle ORM configuration, upgraded drizzle-orm to ^0.45.1, and defined two PostgreSQL migrations establishing credit/collections schema (17 tables with UUIDs, timestamps, JSONB metadata, status fields, foreign keys) and extending obligations/recommendations with escalation and planning columns; added email connections and user namespace tables with idempotent constraint application.
Database Schema Snapshots `migrations/meta/0000_snapshot.json`, `migrations/meta/0001_snapshot.json`	Added full schema snapshots (PostgreSQL version 7) documenting table definitions, column types, indexes, and foreign key relationships for the initial and extended migrations.
TypeScript Schema Definition `src/db/schema.ts`	Added escalation tracking and planner-aware columns to obligations/recommendations tables; introduced new `ccEmailConnections` and `ccUserNamespaces` exported tables with metadata, sync tracking, and uniqueness constraints.
Evidence Integration Types `src/lib/integrations.ts`	Updated `EvidenceFact` and `EvidenceDocument` types to make fact metadata optional, reshaped entities (added `id`, `entity_type`, `confidence`) and amounts (added `id`, `fact_id`, `amount_value`, `confidence`), renamed document fields (`filename` → `file_name`, `uploaded_at` → `created_at`), and changed `searchDocuments` from GET query-param to POST JSON with error-swallowing return (`null` on failure).
Route Implementations `src/routes/timeline.ts`, `src/routes/litigation.ts`, `src/routes/mcp.ts`	Updated case timeline route to normalize missing fact metadata with `null` defaults and reshape entities/amounts to match new API shapes. Updated litigation synthesize-from-case to use `amount_value` instead of `value`. Enhanced MCP server with 48 tools across 12 domains; updated `synthesize_case_facts` for new amount field shape and `get_case_timeline` to optionally filter legal deadlines by date range and fetch related documents from ChittyLedger.
Test Updates `tests/mcp.test.ts`	Updated MCP tools count assertion from 43 to 48 to match expanded toolkit.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Timeline API
    participant ChittyEvidence
    participant ChittyLedger
    participant Database

    Client->>Timeline API: GET /api/v1/timeline/:caseId
    Timeline API->>Database: Query facts by caseId
    Database-->>Timeline API: Return facts with metadata
    Timeline API->>ChittyEvidence: getContradictions(caseId)
    ChittyEvidence-->>Timeline API: Return contradictions
    Timeline API->>Database: Query legal_deadlines by caseId
    Database-->>Timeline API: Return deadlines (optional date filter)
    Timeline API->>ChittyLedger: getEvidenceByCase(caseId)
    ChittyLedger-->>Timeline API: Return document evidence
    Timeline API->>Timeline API: Normalize metadata shapes & flatten<br/>entities/amounts arrays
    Timeline API-->>Client: Return unified timeline events<br/>(facts, contradictions, deadlines, documents)

sequenceDiagram
    participant Client
    participant Litigation API
    participant ChittyEvidence
    participant ChittyConnect/AI Gateway
    participant Database

    Client->>Litigation API: POST /api/v1/litigation/synthesize-from-case
    Litigation API->>Database: Query case facts, obligations, disputes
    Database-->>Litigation API: Return case context
    Litigation API->>ChittyEvidence: Fetch evidence facts & amounts
    ChittyEvidence-->>Litigation API: Return facts with reshaped<br/>entities (id, entity_type, confidence)<br/>amounts (id, fact_id, amount_value, confidence)
    Litigation API->>Litigation API: Synthesize narrative from facts,<br/>obligations, disputes
    Litigation API->>ChittyConnect: POST prompt with synthesized facts<br/>(or fallback to AI Gateway)
    ChittyConnect-->>Litigation API: Return synthesis response
    Litigation API-->>Client: Return synthesized facts JSON

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

fix: add Bearer auth to ledger client #55: The new timeline and MCP routes depend on ledger.getEvidenceByCase() behavior that was introduced or modified in this PR.
feat: case-based fact synthesis from ChittyEvidence #56: Directly overlaps—both add the synthesize_case_facts MCP tool and evidence amount field shape changes (amount_value instead of value) in the same route files.
feat: Litigation AI assistant + command center enhancements #46: Shares code-level modifications to MCP tool surface, litigation endpoints, scrape-job APIs, and related database schema/route implementations.

Poem

🐰 With paws a-twitching, I hop with glee,
Forty-eight tools now dancing free,
Twelve domains bloom like gardens wide,
Evidence flows, timelines collide!
Our schemas grow, so strong and true,
A chirpy feast of facts—brand new! 🥕

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/case-synthesis

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chitcommit and others added 5 commits March 24, 2026 17:55

fix: update MCP tool count in test (43→48) and CLAUDE.md

b02fe13

Added 5 evidence tools: get_case_timeline, get_case_facts, get_case_contradictions, get_pending_facts, synthesize_case_facts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chitcommit merged commit 0b4e594 into main Mar 25, 2026
30 of 31 checks passed

chitcommit deleted the feat/case-synthesis branch March 25, 2026 17:05

coderabbitai Bot mentioned this pull request Mar 25, 2026

fix: canonical entity_type + remove unused docket type #61

Merged

3 tasks

This was referenced Mar 25, 2026

fix: error logging, evidence auth, partial data warnings #63

Merged

fix: redirect phantom ledger API calls to correct services #59

Closed

fix: review audit — SQL branching, error distinguishability, try-catch #65

Merged

coderabbitai Bot mentioned this pull request Mar 26, 2026

fix: log HTTP response body on error in all integration clients #66

Merged

3 tasks

Navigation Menu

Uh oh!

fix: phantom ledger paths, SQL errors, deterministic case refs - #60

fix: phantom ledger paths, SQL errors, deterministic case refs#60
chitcommit merged 5 commits into
mainfrom
feat/case-synthesis

chitcommit commented Mar 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

chatgpt-codex-connector Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Mar 25, 2026

Uh oh!

coderabbitai Bot commented Mar 25, 2026 •

edited

Loading

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

chitcommit commented Mar 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Mar 25, 2026

Uh oh!

github-actions Bot commented Mar 25, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Mar 25, 2026

Uh oh!

coderabbitai Bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chitcommit commented Mar 25, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 25, 2026 •

edited

Loading